[webkit-reviews] review requested: [Bug 27651] [Qt] QWebPluginDatabase API : [Attachment 33730] Allow to explicitly choose a preferred plugin for a mimetype - r2.

[bugzilla-daemon at webkit.org]

Jakub Wieczorek <faw217 at gmail.com> has asked Simon Hausmann
<hausmann at webkit.org> for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33730: Allow to explicitly choose a preferred plugin for a mimetype
- r2.
https://bugs.webkit.org/attachment.cgi?id=33730&action=review

------- Additional Comments from Jakub Wieczorek <faw217 at gmail.com>
(In reply to comment #19)
> (From update of attachment 33438 [details])
> The patch looks good, but I think there's one bug left: The
m_preferredPlugins
> hash keeps PluginPackage instances alife, through the use of RefPtr. When
> calling clear() as well as refresh() we may have to free the references to
> these plugins, to allow the pluginpackage objects to be freed.

Fixed, thanks. :)