[webkit-reviews] review requested: [Bug 27082] bugzilla-tool: Add --no-close switch to land-patches : [Attachment 33728] Patch v3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 29 12:02:18 PDT 2009
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked for review:
Bug 27082: bugzilla-tool: Add --no-close switch to land-patches
https://bugs.webkit.org/show_bug.cgi?id=27082
Attachment 33728: Patch v3
https://bugs.webkit.org/attachment.cgi?id=33728&action=review
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).
* Scripts/bugzilla-tool:
(LandPatchesFromBugs.__init__): Added --no-close switch.
(LandPatchesFromBugs.land_patches): Don't close the bug if the
--no-close switch was used, but call
Bugzilla.clear_attachment_review_flag() on the attachment so it
no longer shows up in the commit queue. Also changed the
behavior when landing multiple patches from obsoleting patches
to clearing each patch's review flag.
* Scripts/modules/bugzilla.py:
(Bugzilla.clear_attachment_review_flag): Added.
---
3 files changed, 38 insertions(+), 6 deletions(-)
More information about the webkit-reviews
mailing list