[webkit-reviews] review granted: [Bug 27119] bugzilla-tool: Add create-bug command : [Attachment 33691] Patch v5

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27119: bugzilla-tool: Add create-bug command
https://bugs.webkit.org/show_bug.cgi?id=27119

Attachment 33691: Patch v5
https://bugs.webkit.org/attachment.cgi?id=33691&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
> +2009-07-28  David Kilzer  <ddkilzer at apple.com>
> +
> +	   <http://webkit.org/b/27119> bugzilla-tool: Add create-bug command
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Implement "create-bug" command for bugzilla-tool.

oooo new format :)


> diff --git a/WebKitTools/Scripts/modules/bugzilla.py
b/WebKitTools/Scripts/modules/bugzilla.py

> +	   if match:
> +	       text_lines =
BeautifulSoup(match.group('error_message')).findAll(text=True)
> +	       error_message = "\n" + '\n'.join(["  " + line.strip() for line
in text_lines if line.strip()])

fwiw, this statment is at the edge of the complexity boundary.	It is hard to
define but when you start seeing "for in if" + other stuff, you're close.

I'd leave it as is though.  Just something to keep in mind in your future
python writing sessions :)