[webkit-reviews] review granted: [Bug 27517] Misc cleanup in DOM Storage. : [Attachment 33672] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 28 14:57:09 PDT 2009
Eric Seidel <eric at webkit.org> has granted Jeremy Orlow <jorlow at chromium.org>'s
request for review:
Bug 27517: Misc cleanup in DOM Storage.
https://bugs.webkit.org/show_bug.cgi?id=27517
Attachment 33672: patch
https://bugs.webkit.org/attachment.cgi?id=33672&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Why remove:
// FIXME: When can this occur?
Also, instead of removing // FIXME: Is the .copy necessary?
it seems replacing it with // copy for safe muti-threaded access
or some similar comment which explains the "why" since clearly the author of
that FIXME didn't understand "why" :)
Otherwise looks fine.
More information about the webkit-reviews
mailing list