[webkit-reviews] review denied: [Bug 27711] SVG Filter need feColorMatrix implementation : [Attachment 33543] SVG feColorMatrix-implementation

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 27711: SVG Filter need feColorMatrix implementation
https://bugs.webkit.org/show_bug.cgi?id=27711

Attachment 33543: SVG feColorMatrix-implementation
https://bugs.webkit.org/attachment.cgi?id=33543&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Woo!  alas, the double casts here:
double red = (double)r, green = (double)g, blue = (double)b, alpha = (double)a;


are unnecessary

And I don't like having that switch in the middle of the main processing loop
-- i'm not entirely sure what can be done to improve it short of something
involving templates ;)