[webkit-reviews] review denied: [Bug 27517] Misc cleanup in DOM Storage. : [Attachment 33501] v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 28 11:09:24 PDT 2009
Eric Seidel <eric at webkit.org> has denied Jeremy Orlow <jorlow at chromium.org>'s
request for review:
Bug 27517: Misc cleanup in DOM Storage.
https://bugs.webkit.org/show_bug.cgi?id=27517
Attachment 33501: v2
https://bugs.webkit.org/attachment.cgi?id=33501&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
I would rather you abstract this into a function, something like this:
static bool privateBrowsingEnabled(frame)
{
#ifdef CHROMIUM
// comment explaing why it's OK for frame to be null
return false;
#else
return frame->....
#endif
}
Otherwis this looks fine.
More information about the webkit-reviews
mailing list