[webkit-reviews] review granted: [Bug 27757] update-webkit-auxiliary-libs, update-webkit-support-libs cause Perl warnings about functions tmpnam and tmpfile : [Attachment 33603] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 28 10:37:25 PDT 2009


Eric Seidel <eric at webkit.org> has granted Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 27757: update-webkit-auxiliary-libs, update-webkit-support-libs cause Perl
warnings about functions tmpnam and tmpfile
https://bugs.webkit.org/show_bug.cgi?id=27757

Attachment 33603: Patch
https://bugs.webkit.org/attachment.cgi?id=33603&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
perldoc -f use
says:

	       If you do not want to call the package's "import" method (for
	       instance, to stop your namespace from being altered), explic-
	       itly supply the empty list:

		   use Module ();

	       That is exactly equivalent to

		   BEGIN { require Module }


Looks fine.

You might want to add more information to the ChangeLog about why this stops
the warning.


More information about the webkit-reviews mailing list