[webkit-reviews] review denied: [Bug 27763] PopupMenuQt lacks proper separator : [Attachment 33622] Patch to replace separator and fix include order.

[bugzilla-daemon at webkit.org]

Adam Treat <treat at kde.org> has denied Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27763: PopupMenuQt lacks proper separator
https://bugs.webkit.org/show_bug.cgi?id=27763

Attachment 33622: Patch to replace separator and fix include order.
https://bugs.webkit.org/attachment.cgi?id=33622&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
>	   if (client()->itemIsSeparator(i)) {
> -	       //FIXME: better seperator item
> -	       m_popup->insertItem(i, QString::fromLatin1("---"));
> +	       m_popup->insertSeparator(i);
>	   } else {

Looks like you can remove the braces now from the if clause.  cpplint didn't
catch it?  Also, you can go ahead and remove the #if 0 code.  If it is
important somehow, that's what we have revision control systems for :)