[webkit-reviews] review denied: [Bug 26952] WebCore Support for the Haiku WebKit port : [Attachment 33037] Patch to add ChromeClient for Haiku WebCore support.

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 33037: Patch to add ChromeClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=33037&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few comments to address and this will be ready to land.

> diff --git a/WebKit/haiku/WebCoreSupport/ChromeClientHaiku.cpp
b/WebKit/haiku/WebCoreSupport/ChromeClientHaiku.cpp
> @@ -0,0 +1,360 @@
> +/*
> + * Copyright (C) 2006 Zack Rusin <zack at kde.org>
> + * Copyright (C) 2006 Apple Computer, Inc.  All rights reserved.
> + * Copyright (C) 2007 Ryan Leavengood <leavengood at gmail.com>
> + *
> + * All rights reserved.

Looks odd as before.
> +
> +#include "Frame.h"
> +#include "FrameView.h"
> +#include "FrameLoadRequest.h"
> +#include "PlatformString.h"
> +#include "HitTestResult.h"
> +
> +#include "NotImplemented.h"

Sort all of these.


> diff --git a/WebKit/haiku/WebCoreSupport/ChromeClientHaiku.h
b/WebKit/haiku/WebCoreSupport/ChromeClientHaiku.h
> + * Copyright (C) 2006 Zack Rusin <zack at kde.org>
> + * Copyright (C) 2007 Ryan Leavengood <leavengood at gmail.com>
> + *
> + * All rights reserved.

Ditto :)

> +#ifndef ChromeClientHaiku_H

Use "_h" instead of "_H"