[webkit-reviews] review granted: [Bug 27697] WorkerThread needs to be refactored to separate out dedicated-worker functionality : [Attachment 33522] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 28 02:21:17 PDT 2009


David Levin <levin at chromium.org> has granted Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 27697: WorkerThread needs to be refactored to separate out dedicated-worker
functionality
https://bugs.webkit.org/show_bug.cgi?id=27697

Attachment 33522: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33522&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> diff --git a/WebCore/workers/WorkerThread.h b/WebCore/workers/WorkerThread.h
> +	   WorkerContext* workerContext() { return m_workerContext.get(); }

Can this ever return 0?

If not, consider making it return WorkerContext&.


More information about the webkit-reviews mailing list