[webkit-reviews] review denied: [Bug 27748] crash w/ stack overflow when same CSS file loaded repeatedly : [Attachment 33597] patch for crash

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 27748: crash w/ stack overflow when same CSS file loaded repeatedly
https://bugs.webkit.org/show_bug.cgi?id=27748

Attachment 33597: patch for crash
https://bugs.webkit.org/attachment.cgi?id=33597&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> -	   ~CSSRuleDataList() { delete m_first; }
> +	   ~CSSRuleDataList() { 

{ should be on the next line.

> +	     CSSRuleData* ptr;
> +	     CSSRuleData* next;
> +	     ptr = m_first;
> +	     while (ptr) {
> +	       next = ptr->next();
> +	       delete ptr;
> +	       ptr = next;
> +	     }
> +	   }

This should use 4 spaces for indentation.

You have also marked the tests as executable which is not correct.  Is there no
programatic way to test this using JS?

r-.