[webkit-reviews] review granted: [Bug 27664] commit-log-editor should allow git commit --amend to regenerate the commit log based on the modifed ChangeLog : [Attachment 33585] 2009-07-24 Pierre d'Herbemont <pdherbemont at apple.com>

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 27664: commit-log-editor should allow git commit --amend to regenerate the
commit log based on the modifed ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=27664

Attachment 33585: 2009-07-24  Pierre d'Herbemont  <pdherbemont at apple.com>
https://bugs.webkit.org/attachment.cgi?id=33585&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> +sub usage
> +{
> +    print "Usage: [--help] [--regenerate-log] <log file>\n";
> +    exit 0;
> +}

The usage() method should always exit with a non-zero status.  I suggest "exit
1;".

r=me with the above change.  Thanks!