[webkit-reviews] review granted: [Bug 27731] [V8] Implement EventListener::reportError for V8 event listeners in worker context. : [Attachment 33567] Proposed Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 27731: [V8] Implement EventListener::reportError for V8 event listeners in
worker context.
https://bugs.webkit.org/show_bug.cgi?id=27731

Attachment 33567: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33567&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> diff --git a/WebCore/bindings/v8/V8WorkerContextEventListener.cpp
b/WebCore/bindings/v8/V8WorkerContextEventListener.cpp
> +    // The callback function on XMLHttpRequest can clear the event listener
and destroys 'this' object. Keep a local reference to it.

I'd get rid of "on XMLHttpRequest" and change "destroys" to "destroy".


> +    // See issue 889829.

I'd remove this issue number here.