[webkit-reviews] review granted: [Bug 27660] createMarkup does not handle CSS properly : [Attachment 33483] fixes the bug but may worsen the bug 26483

[bugzilla-daemon at webkit.org]

Justin Garcia <justin.garcia at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 27660: createMarkup does not handle CSS properly
https://bugs.webkit.org/show_bug.cgi?id=27660

Attachment 33483: fixes the bug but may worsen the bug 26483
https://bugs.webkit.org/attachment.cgi?id=33483&action=review

------- Additional Comments from Justin Garcia <justin.garcia at apple.com>
No need to separate the patch, it's rather small.

+    // All text-decoration-related elements should have been treated as
special ancestor

Small typo.  Should read "as special ancestors".

+    DEFINE_STATIC_LOCAL(const String, divCloseTag, ("</div>"));
+    DEFINE_STATIC_LOCAL(const String, styleSpanOpen, ("<span class=\""
AppleStyleSpanClass "\" style=\""));
+    DEFINE_STATIC_LOCAL(const String, styleSpanClose, ("</span>"));

I'd name it "divClose" for consistency.

r=me