[webkit-reviews] review denied: [Bug 27669] [chromium] Default UI controls for <video> has rendering problems : [Attachment 33480] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 27 11:56:54 PDT 2009
David Levin <levin at chromium.org> has denied Hin-Chung Lam <hclam at google.com>'s
request for review:
Bug 27669: [chromium] Default UI controls for <video> has rendering problems
https://bugs.webkit.org/show_bug.cgi?id=27669
Attachment 33480: patch
https://bugs.webkit.org/attachment.cgi?id=33480&action=review
------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebCore/ChangeLog
> @@ -1,3 +1,23 @@
> +'
Please get rid of this.
> +2009-07-24 Alpha Lam <hclam at google.com>
> +
> + Reviewed by NOBODY (OOPS!).
> +
> + [chromium] Default UI controls for <video> has rendering problems
> + https://bugs.webkit.org/show_bug.cgi?id=27669
> +
> + Fixes the bug that <video> in MediaDocument is 1 pixel tall if
> + it is playing an audio file by changing the style to be 16px
It looks like you made it 32px.
> +
> + There is no layout test provided because this only affects the
> + chromium port.
Couldn't there still could be a layout test (with different results for each
platform: OSX, Chromium, etc.).
More information about the webkit-reviews
mailing list