[webkit-reviews] review granted: [Bug 27323] Better support for non-Cygwin SVN on Windows : [Attachment 33220] Update auto-version.sh to handle different line endings
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 27 11:39:51 PDT 2009
Adam Roben (aroben) <aroben at apple.com> has granted Peter Kasting
<pkasting at google.com>'s request for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323
Attachment 33220: Update auto-version.sh to handle different line endings
https://bugs.webkit.org/attachment.cgi?id=33220&action=review
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> - PROPOSEDVERSION=$(cat "$SRCPATH/VERSION")
> + PROPOSEDVERSION=`cat $SRCPATH/VERSION | sed -r 's/(.*\S+)\s*/\1/'`
Seems like the \s* part of the regex isn't needed, since regex matching is
greedy (ditto for the other sed command).
r=me
More information about the webkit-reviews
mailing list