[webkit-reviews] review requested: [Bug 27663] FontPlatformData for Qt requires mapping from FontWeight to QFont::Weight : [Attachment 33556] Revised Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 27 11:07:04 PDT 2009


Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27663: FontPlatformData for Qt requires mapping from FontWeight to
QFont::Weight
https://bugs.webkit.org/show_bug.cgi?id=27663

Attachment 33556: Revised Patch
https://bugs.webkit.org/attachment.cgi?id=33556&action=review

------- Additional Comments from Mike Fenton <mike.fenton at torchmobile.com>
Patch has been updated.

Based on feedback, toQFontWeight now returns values directly within
intermediary variable.

Switch bold calculation to >Normal from >=Bold to ensure logic matches
calculation provided by QFont.bold().

This does not break any tests.

m_bold variable is required by FontPlatformData and can not be removed without
affecting other platforms.


More information about the webkit-reviews mailing list