[webkit-reviews] review requested: [Bug 27696] Inspector: Console should show completions for the command line APIs : [Attachment 33549] Fixed sortedProperties

[bugzilla-daemon at webkit.org]

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 27696: Inspector: Console should show completions for the command line APIs
https://bugs.webkit.org/show_bug.cgi?id=27696

Attachment 33549: Fixed sortedProperties
https://bugs.webkit.org/attachment.cgi?id=33549&action=review

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
(In reply to comment #3)
> Sort function for Object.sortedProperties is used in
ObjectPropertiesSections. 
> You should that parameter (sortFunc) back.  If sortFunc is not provided then
> the normal sort() is applied so it works out fine.

Sorry my mistake.

> Also what about global functions/classes?  For example:
> String, Date, toString, Number, ...

Great idea. My understanding is that those are specified are {DontEnum} so you
need to keep a list of them. I think I'll file separate bug.