[webkit-reviews] review requested: [Bug 27706] WebCore NPAPI implementations should share more code : [Attachment 33540]=?UTF-8?Q?=202009=2D07=2D27=20=20Tor=20Arne=20Vestb=C3=B8=20=20?=<tor.arne.vestbo at nokia.com>

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has asked  for review:
Bug 27706: WebCore NPAPI implementations should share more code
https://bugs.webkit.org/show_bug.cgi?id=27706

Attachment 33540: 2009-07-27  Tor Arne Vestbø  <tor.arne.vestbo at nokia.com>
https://bugs.webkit.org/attachment.cgi?id=33540&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
Reviewed by NOBODY (OOPS!).

Refactor the common parts out of PluginView::init() and add platformInit()

https://bugs.webkit.org/show_bug.cgi?id=27706

PluginViewMac used to call stop() in some cases, but this error handling
should be unified across the different implementations, so removing for now.

m_hasPendingGeometryChange is now initialized in the initializer list
instead of in PluginViewQt's init()

* plugins/PluginView.cpp:
(WebCore::PluginView::handleEvent):
(WebCore::PluginView::init):
(WebCore::PluginView::bindingInstance):
* plugins/PluginView.h:
* plugins/PluginViewNone.cpp:
* plugins/gtk/PluginViewGtk.cpp:
* plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::platformInit):
* plugins/qt/PluginViewQt.cpp:
* plugins/win/PluginViewWin.cpp:
---
 8 files changed, 71 insertions(+), 100 deletions(-)