[webkit-reviews] review requested: [Bug 27706] WebCore NPAPI implementations should share more code : [Attachment 33539]=?UTF-8?Q?=202009=2D07=2D27=20=20Tor=20Arne=20Vestb=C3=B8=20=20?=<tor.arne.vestbo at nokia.com>

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has asked  for review:
Bug 27706: WebCore NPAPI implementations should share more code
https://bugs.webkit.org/show_bug.cgi?id=27706

Attachment 33539: 2009-07-27  Tor Arne Vestbø  <tor.arne.vestbo at nokia.com>
https://bugs.webkit.org/attachment.cgi?id=33539&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
Reviewed by NOBODY (OOPS!).

Share implementation of PluginView::userAgent() and userAgentStatic()

https://bugs.webkit.org/show_bug.cgi?id=27706

Differences to the original implementation are as follows:

- The Win port used to return 0 for userAgentStatic, but now
returns the quirk mode MozillaUserAgent as the other ports.

* plugins/PluginView.cpp:
(WebCore::PluginView::userAgent):
(WebCore::PluginView::userAgentStatic):
* plugins/PluginViewNone.cpp:
* plugins/gtk/PluginViewGtk.cpp:
* plugins/mac/PluginViewMac.cpp:
* plugins/qt/PluginViewQt.cpp:
* plugins/win/PluginViewWin.cpp:
---
 7 files changed, 49 insertions(+), 87 deletions(-)