[webkit-reviews] review requested: [Bug 27699] Would be nice if build-webkit on Mac respected WEBKITOUTPUTDIR and set SYMROOT/OBJROOT accordingly : [Attachment 33523]=?UTF-8?Q?=202009=2D07=2D27=20=20Tor=20Arne=20Vestb=C3=B8=20=20?=<tor.arne.vestbo at nokia.com>

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 27 01:41:40 PDT 2009


Tor Arne Vestbø <vestbo at webkit.org> has asked  for review:
Bug 27699: Would be nice if build-webkit on Mac respected WEBKITOUTPUTDIR and
set SYMROOT/OBJROOT accordingly
https://bugs.webkit.org/show_bug.cgi?id=27699

Attachment 33523: 2009-07-27  Tor Arne Vestbø  <tor.arne.vestbo at nokia.com>
https://bugs.webkit.org/attachment.cgi?id=33523&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
Reviewed by NOBODY (OOPS!).

build-webkit: Reorder logic for determining the baseProductDir

https://bugs.webkit.org/show_bug.cgi?id=27699

We now do port-spesific probing for the product dir first, and then
fall back to either the generic WEBKITOUTPUTDIR (which now also works
on Mac), or WebKitBuild.

Then we add the git branch if the git branch build option is enabled.

Finally we massage the product dir based on the port. For example the
Mac port will now always set the SYMROOT and OBJROOT configuration for
XCode.

* Scripts/webkitdirs.pm:
---
 2 files changed, 40 insertions(+), 25 deletions(-)


More information about the webkit-reviews mailing list