[webkit-reviews] review denied: [Bug 27673] Inspector: Tab Through Attributes When Editing : [Attachment 33487] Tab Through Attributes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 26 07:36:50 PDT 2009


Timothy Hatcher <timothy at hatcher.name> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27673: Inspector: Tab Through Attributes When Editing
https://bugs.webkit.org/show_bug.cgi?id=27673

Attachment 33487: Tab Through Attributes
https://bugs.webkit.org/attachment.cgi?id=33487&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +		  
attributeElements[i].nextSibling.nextSibling.dispatchEvent(event); // "="
textNode, then the "webkit-html-attribute-value" node

All looks fine except this. I fear this is too fragile. It would be better to
loop through the next siblings until you found "webkit-html-attribute-value".


More information about the webkit-reviews mailing list