[webkit-reviews] review requested: [Bug 20565] Drag and drop issues after DOM modifications : [Attachment 33498] Patch to use m_documentUnderMouse instead of element->ownerDocument() when element is NULL.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 25 16:42:16 PDT 2009


Aaron Golden <aegolden at gmail.com> has asked  for review:
Bug 20565: Drag and drop issues after DOM modifications
https://bugs.webkit.org/show_bug.cgi?id=20565

Attachment 33498: Patch to use m_documentUnderMouse instead of
element->ownerDocument() when element is NULL.
https://bugs.webkit.org/attachment.cgi?id=33498&action=review

------- Additional Comments from Aaron Golden <aegolden at gmail.com>
This patch prevents the crash by avoiding using a NULL result from
elementFromPoint.  I'm not sure if this is what we want or if we should,
instead, prevent elementFromPoint from ever returning NULL in the first place.


More information about the webkit-reviews mailing list