[webkit-reviews] review requested: [Bug 20534] DumpRenderTree needs a way to override settings on a per-test basis : [Attachment 33495] Hopefully the final cut.

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 20534: DumpRenderTree needs a way to override settings on a per-test basis
https://bugs.webkit.org/show_bug.cgi?id=20534

Attachment 33495: Hopefully the final cut.
https://bugs.webkit.org/attachment.cgi?id=33495&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
I think this can be the final version. I've fixed windows DRT to not break the
tests following the one with changed preferences.
Now both mac and windows versions of DRT have
'resetDefaultsToConsistentValues()' functin which is called before each test
and initializes preferences to the regular DRT 'defaults'. I also moved all the
initialization of such 'defaults' into this single function.

Run tests on both mac and windows. On windows (Vista) not all tests pass for me
even before this patch but at least the set of failed tests is the same before
and after.