[webkit-reviews] review granted: [Bug 21794] Middle-click panning should be springloaded while dragging : [Attachment 33404] Pan Scrolling

[bugzilla-daemon at webkit.org]

Jon Honeycutt <jhoneycutt at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 21794: Middle-click panning should be springloaded while dragging
https://bugs.webkit.org/show_bug.cgi?id=21794

Attachment 33404: Pan Scrolling
https://bugs.webkit.org/attachment.cgi?id=33404&action=review

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
> --- a/WebCore/page/EventHandler.cpp
> +++ b/WebCore/page/EventHandler.cpp
> @@ -141,6 +141,8 @@ EventHandler::EventHandler(Frame* frame)
>      , m_mouseDownWasSingleClickInSelection(false)
>      , m_beganSelectingText(false)
>      , m_panScrollInProgress(false)
> +    , m_panScrollButtonPressed(false)
> +    , m_pressedPanScrollInProgress(false)

I think we should stick with the term "spring-loaded pan scroll" rather than
"pressed pan scroll".

> @@ -676,6 +678,9 @@ void EventHandler::setPanScrollCursor()
>      bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() +
ScrollView::noPanScrollRadius);
>      bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() -
ScrollView::noPanScrollRadius);
>	    
> +    if ((east || west || north || south) && m_panScrollButtonPressed)
> +	   m_pressedPanScrollInProgress = true;
> +

It's strange to add this logic to setPanScrollCursor(). We should either move
this logic out or rename the function.

r=me, but please fix the above issues.