[webkit-reviews] review requested: [Bug 26460] Cross-platform ICO decoder should return all icons in file as separate frames, sorted by decreasing quality : [Attachment 33468] part four

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 24 13:40:22 PDT 2009


Peter Kasting <pkasting at google.com> has asked Eric Seidel <eric at webkit.org> for
review:
Bug 26460: Cross-platform ICO decoder should return all icons in file as
separate frames, sorted by decreasing quality
https://bugs.webkit.org/show_bug.cgi?id=26460

Attachment 33468: part four
https://bugs.webkit.org/attachment.cgi?id=33468&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Some cleanup and plumbing I split out of the next patch (which, finally,
implements the desired behavior), in order to make it more readable.

Mainly, this adds a new function ImageDecoder::frameSizeAtIndex(), and hooks
the ImageSource::frameSizeAtIndex() implementations to it; no decoder actually
implements it yet (the ICO decoder will after the next patch).


More information about the webkit-reviews mailing list