[webkit-reviews] review denied: [Bug 26496] iframe isn't loaded until xmlhttprequest in parent completes : [Attachment 32587] Now as a patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied  review:
Bug 26496: iframe isn't loaded until xmlhttprequest in parent completes
https://bugs.webkit.org/show_bug.cgi?id=26496

Attachment 32587: Now as a patch
https://bugs.webkit.org/attachment.cgi?id=32587&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> Index: xml/XMLHttpRequest.cpp
> +#include "Cache.h"

Rather than flagging each instance below, I just do it once here:
Don't use cache() in XMLHttpRequest because XMLHttpRequest may be used on a
thread (in a worker) and cache() isn't threadsafe.

>From workers and in Documents, XHR eventually gets to DocumentThreadableLoader
(on the main thread), so maybe you can do what you want in there.  (Note that
DocumentThreadableLoader may be used by things other than XHR like
importScripts in workers).