[webkit-reviews] review granted: [Bug 27420] Refactor WorkerContext to move DedicatedWorker-specific APIs into DedicatedWorkerContext : [Attachment 33397] Patch addressing dimich's comments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 23 23:42:34 PDT 2009
Adam Barth <abarth at webkit.org> has granted Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 27420: Refactor WorkerContext to move DedicatedWorker-specific APIs into
DedicatedWorkerContext
https://bugs.webkit.org/show_bug.cgi?id=27420
Attachment 33397: Patch addressing dimich's comments
https://bugs.webkit.org/attachment.cgi?id=33397&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Ok. One infinitesimal nit:
> - private:
> + protected:
> WorkerContext(const KURL&, const String&, WorkerThread*);
> + bool isClosing() { return m_closing; }
> + private:
>
> virtual void refScriptExecutionContext() { ref(); }
> virtual void derefScriptExecutionContext() { deref(); }
Please move the private to below the blank line.
More information about the webkit-reviews
mailing list