[webkit-reviews] review granted: [Bug 25552] Support for HTML5 Forms "pattern" attribute : [Attachment 33393] Proposed patch, rev. 2b

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Michelangelo De Simone
<micdesim at gmail.com>'s request for review:
Bug 25552: Support for HTML5 Forms "pattern" attribute
https://bugs.webkit.org/show_bug.cgi?id=25552

Attachment 33393: Proposed patch, rev. 2b
https://bugs.webkit.org/attachment.cgi?id=33393&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

I did have a few more thoughts, but probably not ones that have to be resolved
during review.

The code to get the pattern and value could moved inside the switch so we
wouldn't waste any time getting the pattern or value for input types that don't
support pattern. You might also be able to remove one or both special cases,
since I think compiling an empty regular expression will fail and return false.


Is it really true that an empty value can never mismatch?