[webkit-reviews] review granted: [Bug 27582] [CSS3 Backgrounds and Borders] Add support for inset box shadows : [Attachment 33387] Add support for inset box shadows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 23 15:51:24 PDT 2009


Dave Hyatt <hyatt at apple.com> has granted mitz at webkit.org's request for review:
Bug 27582: [CSS3 Backgrounds and Borders] Add support for inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=27582

Attachment 33387: Add support for inset box shadows
https://bugs.webkit.org/attachment.cgi?id=33387&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Looks good!  Can you put "inset" first in a couple of the test just to make
sure the parsing is covered?

It might not hurt to have a test of inset in between the length and color (and
color and length) also, just to show that the entire property gets discarded.

r=me


More information about the webkit-reviews mailing list