[webkit-reviews] review canceled: [Bug 27610] Add check for line-breaking rule #3 to cpplint : [Attachment 33379] Add check for line-breaking rule #3 to cpplint (try 2)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 23 15:35:59 PDT 2009


Jakob Petsovits <jpetso at gmx.at> has canceled Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27610: Add check for line-breaking rule #3 to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27610

Attachment 33379: Add check for line-breaking rule #3 to cpplint (try 2)
https://bugs.webkit.org/attachment.cgi?id=33379&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Third try. Changes this time:
- Adding goto as fourth exit statement that triggers this check.
- Updating not only the code but also comments to reflect the new situation
with multiple exit statements.
- Make the (otherwise unrelated) label indentation check more permissive,
because currently it doesn't allow for goto labels at the very start of a line.

- Even more unit tests. If I didn't know these are all necessary, I'd say it's
too many of them. But no, these are all necessary.


More information about the webkit-reviews mailing list