[webkit-reviews] review requested: [Bug 27610] Add check for line-breaking rule #3 to cpplint : [Attachment 33379] Add check for line-breaking rule #3 to cpplint (try 2)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 23 14:42:12 PDT 2009


Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27610: Add check for line-breaking rule #3 to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27610

Attachment 33379: Add check for line-breaking rule #3 to cpplint (try 2)
https://bugs.webkit.org/attachment.cgi?id=33379&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
New version, incorporating most feedback from Adam Treat and Dave Levin, both
from the comments in here and from comments in IRC.
Now checks for both "else" and "else if" statements, as well as "break" and
"continue" in addition to "return".

This version does not trigger on exit statements in else-if blocks (only in if
blocks) and also does not (yet?) unify regular expressions for goto labels
(which was suggested by Adam). Apart from that, it's pretty neat though. Please
have another look.


More information about the webkit-reviews mailing list