[webkit-reviews] review granted: [Bug 20215] execCommand('underline') can't remove <U> underlines : [Attachment 33369] fixed per comment
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 23 14:01:50 PDT 2009
Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 20215: execCommand('underline') can't remove <U> underlines
https://bugs.webkit.org/show_bug.cgi?id=20215
Attachment 33369: fixed per comment
https://bugs.webkit.org/attachment.cgi?id=33369&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Should add a comment before:
104 ASSERT(!mutableStyle->getPropertyCSSValue(CSSPropertyTextDecoration)
||
!mutableStyle->getPropertyCSSValue(CSSPropertyWebkitTextDecorationsInEffect));
This comment is confusing:
132 // Always use text-decoration NOT to expose
-webkit-text-decoration-in-effect.
Otherwise looks great!
More information about the webkit-reviews
mailing list