[webkit-reviews] review denied: [Bug 20215] execCommand('underline') can't remove <U> underlines : [Attachment 33318] fixes the bug (non-CSS mode still unsupported)

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 20215: execCommand('underline') can't remove <U> underlines
https://bugs.webkit.org/show_bug.cgi?id=20215

Attachment 33318: fixes the bug (non-CSS mode still unsupported)
https://bugs.webkit.org/attachment.cgi?id=33318&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Just use a raw pointer:
 967			 RefPtr<CSSValueList> valueList =
static_cast<CSSValueList*>(property.value());

These should be static:
		     RefPtr<CSSPrimitiveValue> underline =
CSSPrimitiveValue::createIdentifier(CSSValueUnderline);
 969			 RefPtr<CSSPrimitiveValue> lineThrough =
CSSPrimitiveValue::createIdentifier(CSSValueLineThrough);
 97
Watch out for the LOCAL_STATIC macro.  You can't just use "static" here due to
a GCC bug.

Otherwise this looks great.  I'd like to see the patch one more time though.