[webkit-reviews] review denied: [Bug 21108] Impossible to add an attribute to a node without attributes : [Attachment 33355] Add Attributes to Nodes Improved

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 23 12:55:14 PDT 2009


Timothy Hatcher <timothy at hatcher.name> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 21108: Impossible to add an attribute to a node without attributes
https://bugs.webkit.org/show_bug.cgi?id=21108

Attachment 33355: Add Attributes to Nodes Improved
https://bugs.webkit.org/attachment.cgi?id=33355&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +	       var nodeName = tag.textContent.match(/^<(.*?)>$/)[1];
> +	       tag.textContent = '';
> +	       tag.appendChild(document.createTextNode('<'+nodeName));
> +	       tag.appendChild(node);
> +	       tag.appendChild(document.createTextNode('>'));

Double quote strings and spaces around "+".


More information about the webkit-reviews mailing list