[webkit-reviews] review denied: [Bug 27158] Add WebKit version API to Qt. : [Attachment 32804] Updated patch for generating WebKitVersion.h manually
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 23 12:45:34 PDT 2009
Mark Rowe (bdash) <mrowe at apple.com> has denied robert
<robert at roberthogan.net>'s request for review:
Bug 27158: Add WebKit version API to Qt.
https://bugs.webkit.org/show_bug.cgi?id=27158
Attachment 32804: Updated patch for generating WebKitVersion.h manually
https://bugs.webkit.org/attachment.cgi?id=32804&action=review
------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
This header file should be generated at build time. Checking in a generated
source file doesn't make a lot of sense.
More information about the webkit-reviews
mailing list