[webkit-reviews] review denied: [Bug 27400] Inspector: Automatically Refresh DOM Storage Grids on "storage" event : [Attachment 32993] Live Update both DOM Storage Grids

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27400: Inspector: Automatically Refresh DOM Storage Grids on "storage"
event
https://bugs.webkit.org/show_bug.cgi?id=27400

Attachment 32993: Live Update both DOM Storage Grids
https://bugs.webkit.org/attachment.cgi?id=32993&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> - * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
> + * Copyright (C) 2007, 2008, 2009 Apple Inc.  All rights reserved.

You should add your name and copyright on a new line instead.

> +	   inspectedWindow.addEventListener('storage',
this._storageEventListener, true);

You should use double quotes for strings.

> +	   var flag = (event.storageArea ==
InspectorController.inspectedWindow().localStorage);
> +	   if (this._domStorage) {

An early return would be better here.

> +	       var domStorageLength = this._domStorage.length;
> +	       for (var i = 0; i < domStorageLength; ++i) {
> +		   var domStorage = this._domStorage[i];
> +		   if (flag == domStorage.isLocalStorage) {

Triple equals.

> +		       var view = domStorage._domStorageView;
> +		       if (this.visibleView && view == this.visibleView)

Ditto.