[webkit-reviews] review denied: [Bug 27329] Inspector: Properties Should be Sorted more Naturally : [Attachment 32879] Sort is Applied Correctly, only When Displaying

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 23 11:46:01 PDT 2009


Timothy Hatcher <timothy at hatcher.name> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27329: Inspector: Properties Should be Sorted more Naturally
https://bugs.webkit.org/show_bug.cgi?id=27329

Attachment 32879: Sort is Applied Correctly, only When Displaying
https://bugs.webkit.org/attachment.cgi?id=32879&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +		       if ( !+chunka && !+chunkb ) // chunks are strings of all
0s (special case)

No need for spaces on the inside of the parenthesis.

> +	       }
> +	       else if (chunka !== chunkb)

The else should be on on the same lien as the curly brace.

Maybe move the sort function to Utilities.js so it could be used by other
callers?

I think sorting the completions this way would be good too.


More information about the webkit-reviews mailing list