[webkit-reviews] review denied: [Bug 14410] Dragging a resource in the sidebar should drag it's URL : [Attachment 33008] Make Resource Have a Draggable URL

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 14410: Dragging a resource in the sidebar should drag it's URL
https://bugs.webkit.org/show_bug.cgi?id=14410

Attachment 33008: Make Resource Have a Draggable URL
https://bugs.webkit.org/attachment.cgi?id=33008&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +	   var link = document.createElement('a');
> +	   link.href = this.resource.url;
> +	   link.className = 'invisible';
> +	   for (var i = 0, len = this._listItemNode.children.length; i < len;
++i)
> +	       link.appendChild(this._listItemNode.firstChild);
> +	   this._listItemNode.appendChild(link);

This should use childNodes and not children. You could do this another way
using DOMRange's surroundContents() function.

https://developer.mozilla.org/en/DOM:range.surroundContents

Also use double quotes for strings.