[webkit-reviews] review canceled: [Bug 21108] Impossible to add an attribute to a node without attributes : [Attachment 33226] Add Attributes to Nodes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 23 09:33:49 PDT 2009


Joseph Pecoraro <joepeck02 at gmail.com> has canceled Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 21108: Impossible to add an attribute to a node without attributes
https://bugs.webkit.org/show_bug.cgi?id=21108

Attachment 33226: Add Attributes to Nodes
https://bugs.webkit.org/attachment.cgi?id=33226&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
This has slightly better margins.  When you add a new attribute the textfield
is no longer overlapping text from the attribute/text before it.  This was
because the .editing class was giving it a negative margin.  I overrule that
with a direct style property for the new attribute.


More information about the webkit-reviews mailing list