[webkit-reviews] review denied: [Bug 27488] SVG and XPath memory leaks in V8 bindings : [Attachment 33327] Avoid memory leaks and cleanup use of get() and release() on RefPtrs.

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Mads Ager <ager at chromium.org>'s
request for review:
Bug 27488: SVG and XPath memory leaks in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=27488

Attachment 33327: Avoid memory leaks and cleanup use of get() and release() on
RefPtrs.
https://bugs.webkit.org/attachment.cgi?id=33327&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This is looking good.  A couple questions:

	 if ($attrIsPodType) {
-	     $resultObject = "wrapper";
+	     $resultObject = "wrapper.get()";
+	 }

You should just just WTF::getPtr unconditionally.  It should be free in the
non-RefPtr case.

-    return V8DOMWrapper::convertNodeToV8Object(object.get());
+    return V8DOMWrapper::convertNodeToV8Object(object);
[...]
-    return V8DOMWrapper::convertNodeToV8Object(object.get());
+    return V8DOMWrapper::convertNodeToV8Object(object);

Why no release here?