[webkit-reviews] review granted: [Bug 24540] Fix for missing mmap features in Symbian : [Attachment 32409] Update 2 of patch file for bug 24540

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 23 07:25:01 PDT 2009


Simon Hausmann <hausmann at webkit.org> has granted Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 24540: Fix for missing mmap features in Symbian
https://bugs.webkit.org/show_bug.cgi?id=24540

Attachment 32409: Update 2 of patch file for bug 24540
https://bugs.webkit.org/attachment.cgi?id=32409&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>

> +#if PLATFORM(SYMBIAN)
> +    const size_t MAX_NUM_BLOCKS = 256; // Max size of collector heap set to
16 MB
> +    static RHeap* userChunk = NULL;
> +#endif
> +    

This should not be indented and 0 instead of NULL should be used, as Mark
points out.

That's a really simple and minor issue that I can fix while landing. The rest
looks good to me.


More information about the webkit-reviews mailing list