[webkit-reviews] review granted: [Bug 27594] Windows needs a better nightly launching mechanism : [Attachment 33313] Checkpoint of a new native nightly launcher

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 27594: Windows needs a better nightly launching mechanism
https://bugs.webkit.org/show_bug.cgi?id=27594

Attachment 33313: Checkpoint of a new native nightly launcher
https://bugs.webkit.org/attachment.cgi?id=33313&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> Index: WebKitTools/WebKitLauncherWin/WebKitLauncherWin.cpp
> ===================================================================
> --- WebKitTools/WebKitLauncherWin/WebKitLauncherWin.cpp	(revision 0)
> +++ WebKitTools/WebKitLauncherWin/WebKitLauncherWin.cpp	(revision 0)
> @@ -0,0 +1,111 @@
> +/*
> + * Copyright (C) 2009 Apple Inc. All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + *
> + * 1.  Redistributions of source code must retain the above copyright
> + *	  notice, this list of conditions and the following disclaimer.
> + * 2.  Redistributions in binary form must reproduce the above copyright
> + *	  notice, this list of conditions and the following disclaimer in the
> + *	  documentation and/or other materials provided with the distribution.
> + * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
> + *	  its contributors may be used to endorse or promote products derived
> + *	  from this software without specific prior written permission.

This isn't the license that we typically use on new code.


The copyEnvironmentVariable function isn't used.  Will it be in the future?


> +int APIENTRY _tWinMain(HINSTANCE instance, HINSTANCE, LPTSTR commandLine,
int)
> +{
> +    STARTUPINFO startupInfo = {0};
> +    startupInfo.cb = sizeof(startupInfo);
> +    PROCESS_INFORMATION processInfo = {0};

These should be moved closer to where they're used.

> +    // Launch Safari as a child process
> +    CreateProcess(browserExe, commandLine, 0, 0, FALSE,
NORMAL_PRIORITY_CLASS | CREATE_UNICODE_ENVIRONMENT, 0, path, &startupInfo,
&processInfo);

Do we need some error handling here in case Safari couldn't be launched for
some reason?


r=me