[webkit-reviews] review requested: [Bug 27589] Audio element at default width shouldn't have time field. : [Attachment 33310] WebCore:

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 22 19:16:23 PDT 2009


Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 27589: Audio element at default width shouldn't have time field.
https://bugs.webkit.org/show_bug.cgi?id=27589

Attachment 33310: WebCore:
https://bugs.webkit.org/attachment.cgi?id=33310&action=review

------- Additional Comments from Pierre d'Herbemont <pdherbemont at apple.com>
2009-07-22  Pierre d'Herbemont	<pdherbemont at apple.com>

Reviewed by NOBODY (OOPS!).

Audio element at default width shouldn't have time field.
https://bugs.webkit.org/show_bug.cgi?id=27589

* rendering/MediaControlElements.cpp:
(WebCore::MediaControlTimeDisplayElement::setVisible): Make sure we don't
forget to remember the visibility if there is no renderer.

LayoutTests:

2009-07-22  Pierre d'Herbemont	<pdherbemont at apple.com>

Reviewed by NOBODY (OOPS!).

Audio element at default width shouldn't have time field.
https://bugs.webkit.org/show_bug.cgi?id=27589

* platform/mac-snowleopard/Skipped: Enables back audio-controls-rendering.
* platform/mac/media/audio-controls-rendering-expected.checksum:
* platform/mac/media/audio-controls-rendering-expected.png:
* platform/mac/media/audio-controls-rendering-expected.txt:
---
 7 files changed, 86 insertions(+), 46 deletions(-)


More information about the webkit-reviews mailing list