[webkit-reviews] review denied: [Bug 27099] Elements with display none still gets focus and take part in the tab order : [Attachment 33305] Make isKeyboardFocusable return false when there is no renderer.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 27099: Elements with display none still gets focus and take part in the tab
order
https://bugs.webkit.org/show_bug.cgi?id=27099

Attachment 33305: Make isKeyboardFocusable return false when there is no
renderer.
https://bugs.webkit.org/attachment.cgi?id=33305&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Thanks for tackling this. It looks like you are on the right track.

Unfortunately this is not quite right.

Calling renderer() inside a Node function can give you a false negative. The
object might have a different display type and layout just hasn't run yet. It's
an error to ever call renderer() unless you know that layout is up to date.

Instead, this check needs to be something done by callers that are at a higher
level; they are in a position to know that layout is updated and if renderer()
is 0 it actually means something.