[webkit-reviews] review denied: [Bug 27476] execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration : [Attachment 33304] 2nd submission, no longer adds hasValue to CSSValueList

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 22 16:26:18 PDT 2009


Eric Seidel <eric at webkit.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 27476: execCommand('underline' / 'strikeThrough') doesn't work properly
with multiple styles in text-decoration
https://bugs.webkit.org/show_bug.cgi?id=27476

Attachment 33304: 2nd submission, no longer adds hasValue to CSSValueList
https://bugs.webkit.org/attachment.cgi?id=33304&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
getComputedStyle/getComputedStyle-text-decoration.html shoudl be a js test
(like how editing/execCommand/resources/toggle-text-decorations.js is).  Ping
me if you need help converting it.

missing newline at EOF:
29 var successfullyParsed = true;
030 \ No newline at end of file

Would like to see the converted test. Otherwise this looks fine.


More information about the webkit-reviews mailing list