[webkit-reviews] review granted: [Bug 27323] Better support for non-Cygwin SVN on Windows : [Attachment 33131] Use a common determineSVNRoot() in multiple scripts

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Peter Kasting
<pkasting at google.com>'s request for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 33131: Use a common determineSVNRoot() in multiple scripts
https://bugs.webkit.org/attachment.cgi?id=33131&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> Index: WebKitTools/Scripts/svn-create-patch
> ===================================================================
> --- WebKitTools/Scripts/svn-create-patch	(revision 46134)
> +++ WebKitTools/Scripts/svn-create-patch	(working copy)
> @@ -44,19 +44,21 @@ use strict;
>  use warnings;
>  
>  use Config;
> -use Cwd;
> +use Cwd ();	# "use Cwd;" causes warnings if we later (indirectly) "use
POSIX;"

For consistency, please use "qw()" here in case anyone wants to import methods
later and is confused by the bare parenthesis:

use Cwd qw();  # "qw()" prevents warnings with "use POSIX;" below

r=me