[webkit-reviews] review requested: [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists : [Attachment 33277] Patch to make it possible to build JavaScriptCore as shared library on Linux without symbol files.

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has asked	for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 33277: Patch to make it possible to build JavaScriptCore as shared
library on Linux without symbol files.
https://bugs.webkit.org/attachment.cgi?id=33277&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Currently JavaScriptCore is built as shared library on the Apple Windows and
Mac OS X builds.

The symbols used by WebCore and WebKit are exported in JavaScriptCore via
separate files, one for MSVC and one for Mac OS X gcc. The files contain the
mangled symbol names.

It is cumbersome to maintain these lists and it becomes worse when taking
additional compilers into account, like for example g++ on Linux or RVCT for
ARM. When a new symbol needs to be exported it is necessary to determine their
mangled name for each supported compiler.

This bug tries to track the patches/work needed to replace the separately
maintained export lists with the commonly used export macros.


The initial patch merely adds the export macros where necessary and tweaks the
Visual studio and Xcode based builds to accept them, while keeping the symbol
files in place.


Pending approval for the first patch, the second step is to change the Visual
Studio and Xcode builds to fully utilize the macros and delete the symbol
files. On Windows this step will require the placement of additional export
macros that are not part of the first patch.