[webkit-reviews] review requested: [Bug 27544] cpplint generates false positives for primary includes : [Attachment 33272] Fix cpplint generating false positives for primary includes (try 2)

[bugzilla-daemon at webkit.org]

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27544: cpplint generates false positives for primary includes
https://bugs.webkit.org/show_bug.cgi?id=27544

Attachment 33272: Fix cpplint generating false positives for primary includes
(try 2)
https://bugs.webkit.org/attachment.cgi?id=33272&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Combined the two ifs into one condition in this new patch. This also makes it
apparent that there is no need to make the check stricter than startswith()
after encountering the first occurrence, because it won't be triggered anyways.


> (regarding header_types dict)
> Ahh, now I see.  Perhaps is ok, but not strictly necessary for this patch.

It was actually necessary, because the second _classify_include() apparently
caused some state change which in turn caused some test case to fail. So this
change makes the first _classify_include() to be the only one that's being
called, which ensures proper state tracking.