[webkit-reviews] review denied: [Bug 27524] Add check for correct wtf includes to cpplint : [Attachment 33261] Add check for correct wtf includes to cpplint

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 22 07:49:48 PDT 2009


Adam Treat <treat at kde.org> has denied Jakob Petsovits <jpetso at gmx.at>'s request
for review:
Bug 27524: Add check for correct wtf includes to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27524

Attachment 33261: Add check for correct wtf includes to cpplint
https://bugs.webkit.org/attachment.cgi?id=33261&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
		 'wtf includes inside WebCore should be <wtf/file.h> instead of
"wtf/file.h".')

This should no longer mention 'WebCore'.  Just say, "wtf includes should be..."


And make sure to change the tests to reflect :)

I'd tell you to make the change on landing, but you can't land yet so please
post another patch with that change and then I'll land.


More information about the webkit-reviews mailing list